To string quote #101
Merged
To string quote #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before:
text=[u'4179 Toutatis<br>Radius: 2188 meters <br> Velocity: 11....],
after:
text=[u'4179 Toutatis<br>Radius: 2188 meters <br> Velocity: 1...'],
additionally:
* the end of line (eol) is considered in max len
* the conditional comma is considered in max len
* lines >= to max line length are guaranteed to equal max line length!
* to do the above, spaces, ' ', are filled as necessary.
Also, you have to ensure that the sublist is longer than "[...]". Where "..." == end. Otherwise, you might end up with: ", ...]". Where we're closing something that we no longer open!
Higher chance that we see the end returned.
|
@etpinard, this should fix your quoties issue. It also fixes the closing of lists of lists (which i noticed later) there's a chance that something strange could pop up for ndarrays, like if you had an ndarray of strings... not even sure if you can do that or why you would. for normal |
|
Looks like the Whether it's on purpose or not, this is a nice workaround. |
|
yup, it's because adding "'..'" is 4 characters, which would go over the maximum width. To deal with this, the excess space is just filled with " " (spaces). |
|
I like it 👍 |
|
cool. merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some reformatting for the
to_stringmethod for graph objects.